Skip to content

Conversation

@piotrnarajowski
Copy link
Contributor

This adds support for storing client supported features for clients with a trusted relationship. Fixes Host qualification test
case GATT/SR/GAS/BV-04-C

@github-actions github-actions bot added host size/M Medium PR labels Aug 26, 2025
@github-actions github-actions bot added the size/L Large PR label Aug 26, 2025
@piotrnarajowski piotrnarajowski marked this pull request as ready for review August 26, 2025 12:14
@piotrnarajowski piotrnarajowski changed the title nimble/host: Add support for storing client supported features values. nimble/host: Add support for storing client supported features values Aug 26, 2025
@piotrnarajowski piotrnarajowski marked this pull request as draft August 26, 2025 13:13
@piotrnarajowski
Copy link
Contributor Author

#AutoPTS run mynewt GATT/SR/GAS/BV-04-C

@codecoup-tester
Copy link

Scheduled PR #2114 (comment), board: nrf52, estimated start time: 15:17:06, test case count: 1, estimated duration: 0:11:01

Test cases to be runGATT/SR/GAS/BV-04-C

@codecoup-tester
Copy link

AutoPTS Bot results:
No failed test found.

Successful tests (1)GATT GATT/SR/GAS/BV-04-C PASS

@piotrnarajowski piotrnarajowski marked this pull request as ready for review August 27, 2025 07:44
@piotrnarajowski
Copy link
Contributor Author

@andrzej-kaczmarek PTAL and enable workflows

#endif

static int
ble_store_ram_delete_cl_sup_feat(const struct ble_store_key_cl_sup_feat

Check notice

Code scanning / CodeQL

Unused static function

Static function ble_store_ram_delete_cl_sup_feat is unreachable
}

static int
ble_store_ram_read_cl_sup_feat(const struct ble_store_key_cl_sup_feat

Check notice

Code scanning / CodeQL

Unused static function

Static function ble_store_ram_read_cl_sup_feat is unreachable
}

static int
ble_store_ram_write_cl_sup(const struct ble_store_value_cl_sup_feat

Check notice

Code scanning / CodeQL

Unused static function

Static function ble_store_ram_write_cl_sup is unreachable
Add support for BLE_STORE_OBJ_TYPE_PEER_CL_SUP_FEAT. This is used
for storing values of Client Supported Features for clients with a
trusted relationship.
This adds support for storing client supported features for
clients with a trusted relationship. Fixes Host qualification test
case GATT/SR/GAS/BV-04-C
Extend storage unit tests to cover new object type PEER_CL_SUP_FEAT
Fix code style in ble_store.h
@piotrnarajowski
Copy link
Contributor Author

Fixed coding style issues and updated ble_gatts_peer_cl_sup_feat_update function. Added check for disabling already enabled features for bonded clients


#include <inttypes.h>
#include "nimble/ble.h"
#include "../../host/src/ble_gatt_priv.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs other solution (eg. move declarations for public headers if now used in API)
we should not include private headers in public headers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

host size/L Large PR size/M Medium PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants